search

offirgolan / ember-parachute

Improved Query Params for Ember
https://offirgolan.github.io/ember-parachute
MIT License
199 stars 40 forks source link

Account for changed query params from QueryParams.stateFor #58

Closed chrisseto closed 6 years ago

chrisseto commented 6 years ago

I noticed that query parameters were not being properly deserialized when being passed into the setup hook due to changed always being an empty object.

It looks state will have the most accurate representation of what has actually changed so I merged that into the changed object.

Not sure if this is the best way to fix this but it's working for my use case.

I don't think this is a common issue, I only discovered it because I was adding a negative number to my page parameter rather than subtracting from it.

"201" - 1  // 200
"201" + -1  // 201-1
chrisseto commented 6 years ago

Disregard, it looks like there's a compatibility issue with lazy loaded ember engines