Closed schimini closed 1 year ago
this is awesome, I love it shouldn't we either commit a prettierrc file or add config to the package.json?
Nice! I think having a prettierrc is good . Right now without it I think it uses the recommended defaults. I left it like this so that you could configure it as you like :)
On Tue, Jan 10, 2023, 22:49 Luis Rodriguez @.***> wrote:
this is awesome, I love it shouldn't we either commit a prettierrc file or add config to the package.json?
— Reply to this email directly, view it on GitHub https://github.com/offset-dev/strapi-calendar/pull/25#issuecomment-1377996114, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN4CJ7K5IJFKNA7RLLIUOLWRXRPPANCNFSM6AAAAAATXBMNSM . You are receiving this because you authored the thread.Message ID: @.***>
Could you add the config file from the strapi project and reformat? This will reduce the amount of changes and implement the same style. We should be ready to merge after that.
Update: I changed the target branch, could you also resolve conflicts? Thanks for the help :)
@LuisRodriguezLD done :)
PS: I tested if was using the config file properly and it is (changed some properties, ran lint and reverted)
Thanks.
Could you run yarn lint --fix
again?
The action is failing
Sorry i thought I did it :s
Btw if I ever take to long to respond, this PR is editable by maintainers so you're free to do what you want :)
Great job. Merging now!
Well i don´t want to mess with you project too much. but I added prettier to the project. This way, if you guys were interested in anything like this, you could merge this one, and since I've updated my master branch to have all your latest changes + prettier config + cross-plugin functionality the other merge would be a lot easier to check.