search

offspot / container-images

OCI images for use in Kiwix Offspot
GNU General Public License v3.0
0 stars 1 forks source link

Add contentfilter container image #63

Open kelson42 opened 2 years ago

kelson42 commented 2 years ago

This is necessary to create images for Bard.

Kind of follower of https://github.com/offspot/kiwix-hotspot/issues/613.

rgaudin commented 2 years ago

Wouldn't this be part of our project.json ? Unless necessary, I suggest we keep our kiwix-related tickets that don't affect the creator outside this repository

kelson42 commented 2 years ago

@rgaudin I don't expect random container images to work out-of-the box with image-creator because (at least):

This is why, I have put it here first. Like a few other containers (for example the captive portal, reverse proxy, ...), both orgs might use it.

What would be concretly a better place? Offspot/content-filter?

rgaudin commented 2 years ago

image-creator is a software for building the image. What you are mentioning is all very important but that's part of the solution, not the creator. There will be zero code about this in this repo (some might require tighter integration, most likely at base-image level) so issues about those should not pollute this repo.

We should to discuss whether we want a single repo to share code and issues about all those pieces and/or/if we need an overview one as well.

rgaudin commented 1 year ago

Now that bard has shipped and we know it won't reconcile its codebase, is this image/feature still relevant generally ? Precisely: should we implement this? drop it? implement it later?

kelson42 commented 1 year ago

@rgaudin It's important we maintain it IMO and provide it as (optional?) tool in the imager.

kelson42 commented 1 year ago

@rgaudin It's strategic for Kiwix that this tool is available, better soon than later, in Kiwix Hotspot. The reason is that we need to it, to remove the duty of censorhip of the shoulders of Kiwix.

kelson42 commented 3 months ago

@rgaudin I suspect this issue can be closed?

rgaudin commented 3 months ago

There is an image but it's not working. It's just the bard code and it requires both work on the image and in the proxy configuration to make it work. I found it well located at container-images for that reason

kelson42 commented 3 months ago

@rgaudin How much additional work would be needed to have it as proper feature? @Popolechien To me it would be really nice to have this in the feature set... but not sure about the priority

rgaudin commented 3 months ago

I'd say 1d ± .5d

Popolechien commented 3 months ago

Honestly to me it is super-low priority. There's no actual demand for it atm. I'd file it under "nice to have".

kelson42 commented 3 months ago

My main concern is having work done not reaching end-users. I would propose to: