offspot / imager-service

Create Kiwix Hotspot microSD cards online
https://imager.kiwix.org/
GNU General Public License v3.0
14 stars 6 forks source link

Prevent order if configuration is empty #144

Closed Popolechien closed 4 years ago

Popolechien commented 4 years ago

A user launched an order (L199R5E1E) with no content in its config - this crashed the card creation. It would be better if the user would be prevented from ordering on an empty stomach (or config).

kelson42 commented 4 years ago

@Popolechien This is definitely a bug @rgaudin I think we should be able to create a card with no content

rgaudin commented 4 years ago

hum, there is no such thing as an empty config. I guess you mean without content (which is what's in the link you provided). That's a reasonable request and should not be prevented.

The problem in the order you mention is not in the installer (it worked fine) but in the download of the image on your physical worker.

The log indicates a network issue during the file transfer: it starts the FTP negociation, validates the credentials and then it retries a few times then gets the size, but ends up with a (Failed to establish connection, cause: Connection refused).

I just tried the same URI from my computer and it worked so I suggest you simply retry as this really looks like a network issue.