search

offspot / imager-service

Create Kiwix Hotspot microSD cards online
https://imager.kiwix.org/
GNU General Public License v3.0
12 stars 6 forks source link

Fail message returns wrong link #222

Closed Popolechien closed 3 years ago

Popolechien commented 3 years ago

Order #5fdc6c9e98c8bf437d0ea98f failed and the user received a notification email with an incorrect Order ID link pointing to https://cardshop.hotspot.kiwix.org/orders/f/5fdc6c9e98c8bf437d0ea98f (which returned an error) instead of all-orders/f/etcetcetc

b-thebest commented 3 years ago

Can I take up this issue?

rgaudin commented 3 years ago

@b-thebest sure

b-thebest commented 3 years ago

@rgaudin Thank you for assigning this task. I am new to open source community. Could you please provide me some source in order to understand problem more clearly and work on it.

rgaudin commented 3 years ago

The ticket seems suffisciently detailed. We send an email in case of error with an error. The link included in that email points to a wrong URL. Check the source code to find what needs to be fixed

b-thebest commented 3 years ago

@rgaudin I have one doubt, Do we have to change link like this: https://cardshop.hotspot.kiwix.org/ orders/f/5fdc6c9e98c8bf437d0ea98f --> https://cardshop.hotspot.kiwix.org/ all-orders/f/5fdc6c9e98c8bf437d0ea98f or https://cardshop.hotspot.kiwix.org/ orders/f/5fdc6c9e98c8bf437d0ea98f --> https://cardshop.hotspot.kiwix.org/ all-orders/f/etcetcetc

rgaudin commented 3 years ago

@b-thebest , acually trying to answer you I realized that the link is correct. The error mentioned by @Popolechien is due to that ID not existing. @Popolechien would you still have that email? I wonder how you could get such a link.

Popolechien commented 3 years ago

@rgaudin Nope sorry, just checked and the email was deleted and the trash emptied :-/