Use config name in confirmation email subjects

offspot / imager-service

Create Kiwix Hotspot microSD cards online

https://imager.kiwix.org/

GNU General Public License v3.0

13 stars 6 forks source link

Use config name in confirmation email subjects #296

Open Popolechien opened 2 years ago

Popolechien commented 2 years ago

Order IDs only have value from our side but in tems of UX it is much better to know upfront what's up, particularly after a couple of distinct orders: Screenshot_20220314-110621 I would suggest rephrasing the subject line to

_[Kiwix Hotspot] Config_name is on its way!_
[Kiwix hotspot] Config_name is ready to download

rgaudin commented 2 years ago

Renamed the issue as you want it in the subject ; we already have it in the email body

kelson42 commented 4 months ago

It should not be "Hotspot"

rgaudin commented 4 months ago

It should not be "Hotspot"

What shouldn't be Hotspot ?

rgaudin commented 4 months ago

Sample subject: [Kiwix Imager] Order #66221e71bb5 failed!

rgaudin commented 4 months ago

I understand the request as wanting to change it to:

[Kiwix Imager] {MyConfigName} Order #66221e71bb5 failed!

kelson42 commented 4 months ago

@rgaudin Yes, sorry, I meant: shouldn't be "Cardshop".

Popolechien commented 4 months ago

Since users can't have concurrent orders going, what's the point of giving an order number? [Kiwix Imager] Order {MyConfigName} has failed!

rgaudin commented 4 months ago

Since users can't have concurrent orders going, what's the point of giving an order number? [Kiwix Imager] Order {MyConfigName} has failed!

Indeed in the email subject it can be replaced with the config name