Edupi resource URL should be an URL

offspot / imager-service

Create Kiwix Hotspot microSD cards online

https://imager.kiwix.org/

GNU General Public License v3.0

11 stars 6 forks source link

Edupi resource URL should be an URL #301

Closed rgaudin closed 2 months ago

rgaudin commented 2 years ago

Almost never used the Edupi resource URI (which should be a ZIP file) apparently accepts any string (A user entered “wikipedia”) which would fail at the installer's download stage.

We should probably check that:

It's an URI
It's reachable at the time of addition (HEAD request)

Popolechien commented 2 months ago

Is this still a valid issue since we got rid of Edupi?

rgaudin commented 2 months ago

It's not valid, not because we got rid of edupi (we still allow pre-populated the filemanager) but because it's been implemented