offspot / imager-service

Create Kiwix Hotspot microSD cards online
https://imager.kiwix.org/
GNU General Public License v3.0
13 stars 6 forks source link

image.yaml builder #312

Closed rgaudin closed 11 months ago

rgaudin commented 1 year ago

An image.yaml builder needs to be included in Cardshop. Rendered YAML would be included in Configuration.to_dict() so it's passed to the scheduler and eventually the worker.

kelson42 commented 1 year ago

I wonder if this would not be better to create a dedicated library now considering that this is foreseen to be integrated in many softwares?

rgaudin commented 1 year ago

what other software ? until we have a content catalog, this is gonna be glue taking content name and inserting various values inside a dict that renders as yaml.

If you're thinking about bsf, I don't see how it can be reused at the moment.

But you wrote "many" so maybe we're not on the same page

kelson42 commented 1 year ago

Kiwix imager will need it

rgaudin commented 1 year ago

Oh right, sorry. Will be its own module until then.

No need to bring additional library constraints for now. We'll extract it when we need it.