JSON-included logo not imported

offspot / imager-service

Create Kiwix Hotspot microSD cards online

https://imager.kiwix.org/

GNU General Public License v3.0

13 stars 6 forks source link

JSON-included logo not imported #322

Closed Popolechien closed 1 year ago

Popolechien commented 1 year ago

How to reproduce:

Download config which includes a logo in it
(optional) Open JSON and see that there is a data field with code
Import config
Image is missing

rgaudin commented 1 year ago

I can't reproduce. Might be related to the actual logo and/or JSON export. Can you please share it with me?

Popolechien commented 1 year ago

Done via Slack.

rgaudin commented 1 year ago

Thank you ; it's a side effect of #225. Because we don't check the file format of uploaded logo, we end up with a JPEG logo (that works on the box currently) while we should only accepts PNG (#214). We thus export the JSON file with the JPEG image inside but when we import a JSON, we check the file format (🤷‍♂️) and silently remove non-expected format.

I am closing this in favor of #225 and #214