offspot / imager-service

Create Kiwix Hotspot microSD cards online
https://imager.kiwix.org/
GNU General Public License v3.0
13 stars 6 forks source link

Remove Custom CSS #344

Closed rgaudin closed 9 months ago

rgaudin commented 9 months ago

Custom CSS has never been used and is not supported anymore.

kelson42 commented 9 months ago

Not convinced - at all - this is a good idea... This is a very important feature and I hardly can understand why this isnot used... there has to be an other problem somewhere

rgaudin commented 9 months ago

It's a multi-layer issue:

Offspot apps currently don't support it. Captive portal and hwclock never did. The homepage used to but the DOM has changed (it was ideascube's) and is about to change ~soon.

The creation tool doesn't support it but it may not require any change once the branding is mounted on all apps.

The cardshop must collect the styles and we've seen that just asking for a CSS file is not convenient. Requesting a CSS file has multiple disadvantages:

For those reasons, we're dropping the custom CSS feature and will later introduce #348

rgaudin commented 9 months ago

Fixed in d827cbb