Credits are not re-credited after build failure

offspot / imager-service

Create Kiwix Hotspot microSD cards online

https://imager.kiwix.org/

GNU General Public License v3.0

14 stars 6 forks source link

Credits are not re-credited after build failure #89

Closed Popolechien closed 4 years ago

Popolechien commented 5 years ago

I just noticed that in spite of what the notification email said, credits are not added back to the acccount after failure to build.

kelson42 commented 4 years ago

I’m not really sure this should happen. Builds should not fail, and if this happen then admin should be notified and the build should be retried/fixed.

rgaudin commented 4 years ago

agrees yet that requires us to fix a few issues incurring failures that would fail again on retries :

enforce forbidden inputs
switch to OPDS.

rgaudin commented 4 years ago

@kelson42 I know you want to reduce number of bugs but we are loosing information here... do we have a ticket requesting retry on failures ?

kelson42 commented 4 years ago

@rgaudin What is sure is that this ticket won't be implemented. If someone wants something else, then new tickets has to be done.

To me the only thing which is clear, is that if a build fails then Stéphane (as app manager) and we (developers) need to be notified and then the bug analysed, the build restarted after or before a fix. I don't think I want an automatic retry here, even if I won't oppose if you have good arguments to require one.

rgaudin commented 4 years ago

The bug is : we say we will refund on failures while we don’t. You closed that ticket for valid reasons as we want to pursue a different approach.

Without opening a ticket for that other approach we’re just loosing track of that bug (hence, loss of information).

kelson42 commented 4 years ago

Ok, my request is that we rephrase this email. Where is that message stored in the source code?