search

offspot / imager-service

Create Kiwix Hotspot microSD cards online
https://imager.kiwix.org/
GNU General Public License v3.0
14 stars 6 forks source link

Simple(r) error message when size exceeded #99

Closed Popolechien closed 3 years ago

Popolechien commented 5 years ago

If a user tries to order a card that exceeds the allowed limit of 256Gb and orders a card/download anyway, then they are taken to a server log listing the error. Capture d’écran 2019-07-01 à 08 26 39 It would be simpler if they would be shown a regular red ink error message (e.g. "Max card size exceeded. Please update configuration")

rgaudin commented 5 years ago

yes, this is a debug page so user should never see it.

kelson42 commented 3 years ago

@rgaudin @Popolechien Still happening?

Popolechien commented 3 years ago

There is no error message per se, but it's not possible to push an order anymore because there is no corresponding media. However it is not clear that maximum size has been exceeded. image

kelson42 commented 3 years ago

It is nice that there is no user visible exception. That said, I guess the ticket can not be closed because backend is not secured. @rgaudin You confirm.

rgaudin commented 3 years ago

No, it looks like it was a typo in the code that has been long fixed. Closing