ofgulban / segmentator

3D MRI data exploration and segmentation tool.

https://github.com/ofgulban/segmentator/wiki

BSD 3-Clause "New" or "Revised" License

74 stars 13 forks source link

Removed redundant sys argument retrieval. #56

Closed ingo-m closed 7 years ago

ingo-m commented 7 years ago

I removed the redundant sys argument retrieval. The input arguments were retrieved twice, once using sys, and once using argparse. The list (args) retrieved with sys was subsequently overwritten by a namespace object from argparse. This is just a suggestion, but I think it is more pythonic not include redundant code.

codecov-io commented 7 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    3.65%   3.65%           
======================================
  Files           6       6           
  Lines         847     847           
======================================
  Hits           31      31           
  Misses        816     816

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 01655ae...6bb41bf. Read the comment docs.

ofgulban commented 7 years ago

Could you create a PR to devel? All changes should go through devel branch first

ingo-m commented 7 years ago

Ok I will close this one and open another one to devel.

ofgulban commented 7 years ago

This indicates that we should have a contributing file soon :)

ingo-m commented 7 years ago

Absolutely.