search

ofi-cray / libfabric-cray

Open Fabric Interfaces
http://ofiwg.github.io/libfabric/
Other
16 stars 9 forks source link

prov/gni: Restrict mr mode bits to basic #1365

Closed jswaro closed 7 years ago

jswaro commented 7 years ago

For the GNI provider, only basic memory registration is supported at this time. This commit fixes the provider to only use basic memory registration.

In addition, this commit resolves problems with the GNI provider on fi_getinfo where the GNI fi_getinfo equivalent function call would modify the hints structure, which is not permitted.

Requires patch for ofiwg/libfabric#3037

Signed-off-by: James Swaro jswaro@cray.com

closes #1341 closes #1361 closes #1187

sungeunchoi commented 7 years ago

Rather than changing the MR mode to GNIX_DEFAULT_MR_MODE, we should use a constant or variable that can be set (either by env var or something TBD) to enable testing of modes other than the default. We may have to do more to get other MR modes working, but this sets us up for that.

jswaro commented 7 years ago

Rather than changing the MR mode to GNIX_DEFAULT_MR_MODE, we should use a constant or variable that can be set (either by env var or something TBD) to enable testing of modes other than the default. We may have to do more to get other MR modes working, but this sets us up for that.

Since I'm doing the scalable MR work anyway, I'll make it part of that change. I used a define so that I could do a simple replacement when it got to that point.

jswaro commented 7 years ago

closes #1187

No additional changes are required at this time to complete 1187

sungeunchoi commented 7 years ago

BTW if you don't put the "Closes" comment in the description, it does not automatically close the issue.

jswaro commented 7 years ago

This PR will remain open until ofiwg/libfabric#3037 is committed and pulled into the ofi-cray/libfabric repository.