search

ofi-cray / libfabric-cray

Open Fabric Interfaces
http://ofiwg.github.io/libfabric/
Other
16 stars 9 forks source link

prov/gni: criterion tests - initialize stack variable #1385

Closed hppritcha closed 6 years ago

hppritcha commented 6 years ago

Per the fi_cq man page, the err_data field in the CQE error structure is an option for a provider to provide additional information, not something that has to be non-NULL.

Prior to support for the FI_SOURCE feature, the GNI provider happened to always have this field set (though not having any useful information in most cases). Now we are getting random "Bad provider data..."

Change the criterion tests to only check for non-NULL err_data field in CQEs when the err_data_size field is non-zero.

Fixes ofi-cray/libfabric-cray#1374

Signed-off-by: Howard Pritchard howardp@lanl.gov

jshimek commented 6 years ago

Looks good though you might want to update the PR Comment to state how your fixing it now.