search

ofi-cray / libfabric-cray

Open Fabric Interfaces
http://ofiwg.github.io/libfabric/
Other
16 stars 9 forks source link

prov/gni: fix issue with FI_SOURCE_ERR #1410

Closed hppritcha closed 7 years ago

hppritcha commented 7 years ago

Fix problems with use of FI_SOURCE/FI_SOURCE_ERR. Fixes ofi-cray/libfabric-cray#1409

Part of the reason this problem wasn't detected was that Criterion was not covering it for several reasons including 1) tests for FI_SOURCE/FI_SOURCE_ERR were not enabled 2) changes to better test FI_MULTIRECV conflicted with testing FI_SOURCE/FI_SOURCE_ERR

To deal with this, activate the tests in rdm_sr.c and moved the multireceive specific tests to a separate file just for multirecv testing.

A future PR may deal with cleanup of redundant code in the Criterion tests.

Signed-off-by: Howard Pritchard howardp@lanl.gov

hppritcha commented 7 years ago

@jswaro I want to improve one of the tests a bit before merging

jswaro commented 7 years ago

ok

hppritcha commented 7 years ago

curious. let's see if lanl ci fails again. bot:lanl:retest