search

oficiodesign / initial-css

MIT License
4 stars 1 forks source link

Fix visually-hidden and visually-hidden--focusable mixings #105

Closed Eduruiz closed 1 year ago

Eduruiz commented 3 years ago

I think I found that the visually-hidden mixing is actually focusable, making the --focusable one redundant.
I made a test case here where you can see the focus changing from the github to the google link even with the link being visually hidden.
adding visibility: hidden; fix it, but I'm not sure if it breaks something else.

robsonsobral commented 3 years ago

As we don't need to be backward compatible, we can "fix" it.

(I've a huuuuuuuuuuuuuuuuuuuge amount of improvements to release)