ofiwg / libfabric

Open Fabric Interfaces
http://libfabric.org/
Other
555 stars 376 forks source link

prov/verbs: Optimize search for device max inline size #10117

Closed zachdworkin closed 3 months ago

zachdworkin commented 3 months ago

Let the user set the FI_VERBS_INLINE_SIZE environment variable to decide the maximum size of an inline transfer. The getinfo call will check if the device is capable of this size. If it is capable it will use it. If it not capable then the size is too big and we can goto the backwards search to find the largest inline size that is smaller than the FI_VERBS_INLINE_SIZE variable.

If a user wants the maximum inject size that a device can do then they should set this FI_VERBS_INLINE_SIZE variable to 0 so that the device can find its largest inject size.

zachdworkin commented 3 months ago

bot:aws:retest

zachdworkin commented 3 months ago

@shijin-aws is this related to the AWS CI downtime or is it a different issue?

shijin-aws commented 3 months ago

Yes it is, you can ignore. BTW I have fixed the AWS CI now.

zachdworkin commented 3 months ago

@shijin-aws so it is okay to merge this then? Even though AWS CI failed?

shijin-aws commented 3 months ago

@zachdworkin yes please, AWS CI disabled verbs in the build anyway

zachdworkin commented 3 months ago

@j-xiong Can this be merged? Shijin said AWS CI doesnt test verbs.