search

ofiwg / libfabric

Open Fabric Interfaces
http://libfabric.org/
Other
527 stars 369 forks source link

prov/efa: log hmem iface name instead of enum #10136

Closed wenduwan closed 4 days ago

wenduwan commented 1 week ago

Logging improvement

wenduwan commented 1 week ago

Hey @zachdworkin do you know the reason for appveyor failure?

zachdworkin commented 1 week ago

@shijin-aws It doesn't look like appveyor ran anything. There is no job in the history for this PR either. I think it has to do with this: "Appveyor continually checks for branch mergablility for 10 seconds after a PR is opened before running". Since this PR is still checking for ability to merge automatically I suspect that it stopped trying and reported this " AppVeyor was unable to build non-mergeable pull request" failure. I have noticed that github has been lagging recently with things like this so its possible that its just a quirk that needs to get ironed out. I am about to merge an update for Intel CI with #10133. I would rebase to grab those changes and then repush to see if that can trigger appveyor to re-run.

zachdworkin commented 1 week ago

@shijin-aws I just merged it. Can you rebase and try again to re-trigger appveyor? I also aborted your Intel-CI job so that it saves time on our resource since you will repush shortly.

shijin-aws commented 6 days ago

bot:aws:retest

shijin-aws commented 6 days ago

AWS CI failure seems real, but it's not clear to me now how it's related to your change

shijin-aws commented 6 days ago

AWS CI failure seems real, but it's not clear to me now how it's related to your change

Figured out the bug, need to rebase on https://github.com/ofiwg/libfabric/pull/10144

shijin-aws commented 4 days ago

bot:aws:retest

wenduwan commented 4 days ago

AWS CI passed. Should be good to go.