search

ofiwg / libfabric

Open Fabric Interfaces
http://libfabric.org/
Other
555 stars 376 forks source link

fabtests: Add benchmark option for `FI_OPT_MAX_MSG_SIZE` #10147

Closed darrylabbate closed 2 months ago

darrylabbate commented 3 months ago

This adds an option (-X) for benchmark tests; corresponding to the endpoint options FI_OPT_MAX_MSG_SIZE. fi_setopt() is called during EP enable with the value requested by the user.

This also includes a few related minor changes to the EFA provider.

shijin-aws commented 3 months ago

Do you need another commit to add such test to pytest?

darrylabbate commented 3 months ago

Do you need another commit to add such test to pytest?

Are you asking for a default pytest? I figure we can have a follow-up PR for some kind of EFA zero-copy fabtest.

shijin-aws commented 3 months ago

Are you asking for a default pytest? I figure we can have a follow-up PR for some kind of EFA zero-copy fabtest.

I prefer to just have it in this PR so we can make it tested by AWS CI. It should be a straightforward incremental change, like what we have in test_rdm.py

shijin-aws commented 2 months ago

@j-xiong can you review https://github.com/ofiwg/libfabric/pull/10147/commits/fa178bb1fe878de3be948304e3504a9b8da92ef8

shijin-aws commented 2 months ago

I opened a new PR that reworked the last commit of this PR https://github.com/ofiwg/libfabric/pull/10168