search

oflatt / soniconion

8 stars 0 forks source link

Drawing on Small Screens Broken #3

Open ryan-berger opened 3 years ago

ryan-berger commented 3 years ago

I was taking a look at the soniconion docs on one of my sideways monitors, and I noticed that some of the example songs were cut off like so:

image

I haven't looked into the drawing code here, but I'm wondering if the editor could be more responsive. If it can't use a flexbox or grid-like scaling mechanism, I wonder if a zoom in/out Lucidchart-esque editor would be helpful for songs.

I'm hoping to look into the project more so that I could submit a PR to fix this myself, but I thought I would just open the issue so it is at least here

oflatt commented 3 years ago

Oh yeah, so I'm planning on making functions wrap around vertically, so you can have multiple rows of functions. I'm also planning on making tabs so you can have multiple "files" to organise functions in. If you feel like taking a stab at this feel free, the viewstructure file creates the information for drawing functions.

On Sun, 17 Jan 2021, 9:45 pm Ryan Berger, notifications@github.com wrote:

I was taking a look at the soniconion docs on one of my sideways monitors, and I noticed that some of the example songs were cut off like so:

[image: image] https://user-images.githubusercontent.com/14855325/104873026-c08edd80-590c-11eb-8e9e-0dcedcd21b19.png

I haven't looked into the drawing code here, but I'm wondering if the editor could be more responsive. If it can't use a flexbox or grid-like scaling mechanism, I wonder if a zoom in/out Lucidchart-esque editor would be helpful for songs.

I'm hoping to look into the project more so that I could submit a PR to fix this myself, but I thought I would just open the issue so it is at least here

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/oflatt/soniconion/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBA5NLKANIGNUQ5GGIJXA3S2O4HLANCNFSM4WGW2YAQ .

oflatt commented 3 years ago

Besides that a zoom feature is planned and is going to be easy for me to implement (:

On Mon, 18 Jan 2021, 7:33 am Oliver Flatt, oflatt@gmail.com wrote:

Oh yeah, so I'm planning on making functions wrap around vertically, so you can have multiple rows of functions. I'm also planning on making tabs so you can have multiple "files" to organise functions in. If you feel like taking a stab at this feel free, the viewstructure file creates the information for drawing functions.

On Sun, 17 Jan 2021, 9:45 pm Ryan Berger, notifications@github.com wrote:

I was taking a look at the soniconion docs on one of my sideways monitors, and I noticed that some of the example songs were cut off like so:

[image: image] https://user-images.githubusercontent.com/14855325/104873026-c08edd80-590c-11eb-8e9e-0dcedcd21b19.png

I haven't looked into the drawing code here, but I'm wondering if the editor could be more responsive. If it can't use a flexbox or grid-like scaling mechanism, I wonder if a zoom in/out Lucidchart-esque editor would be helpful for songs.

I'm hoping to look into the project more so that I could submit a PR to fix this myself, but I thought I would just open the issue so it is at least here

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/oflatt/soniconion/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBA5NLKANIGNUQ5GGIJXA3S2O4HLANCNFSM4WGW2YAQ .