search

ofload / native_updater

Flutter package to embed native in-app updater
MIT License
56 stars 48 forks source link

Increase widget customization #22

Closed Macacoazul01 closed 2 years ago

Macacoazul01 commented 3 years ago

@milhomem @haritsfahreza

milhomem commented 3 years ago

Hi @Macacoazul01 , very nice PR and I'm grateful for that.

We can accept your PR if you split your commits and follow our https://github.com/ofload/native_updater/blob/master/CONTRIBUTING.md guidelines.

It's a simple thing but helps us to keep the code and changes organised and we are able to reason and decide what every change needs or causes before releasing a new version of the plugin.

From your changes, I can see you could split your commits into 3.

1- Update documentation and example files 2- Improve ability to translate/customise messages 3- Upgrade dependencies

I will comment on individual lines for more clarity.

Macacoazul01 commented 3 years ago

Hi @Macacoazul01 , very nice PR and I'm grateful for that.

We can accept your PR if you split your commits and follow our https://github.com/ofload/native_updater/blob/master/CONTRIBUTING.md guidelines.

It's a simple thing but helps us to keep the code and changes organised and we are able to reason and decide what every change needs or causes before releasing a new version of the plugin.

From your changes, I can see you could split your commits into 3.

1- Update documentation and example files 2- Improve ability to translate/customise messages 3- Upgrade dependencies

I will comment on individual lines for more clarity.

I can't do this right now, it takes time to comment on everything and make 3 prs instead of one. You guys can use this pr as an suggestion to create or own new update.

The point of this PR is to make the library useful on other languages instead of just english (item 2).

The item 1 i've made because it was broken and the 3 just to push to the most recent ones