ofmodemsandmen / ROOterSource2305

ROOter 23.05
Other
9 stars 19 forks source link

ext-rooter4 (with ext-rooter8) problem #9

Open Demiurge67 opened 9 months ago

Demiurge67 commented 9 months ago

Collected errors:

nathhad commented 8 months ago

Took an hour, but I found the source of this one. I can show you where to make a change in the build system to get yours to build temporarily, and then once DM has a moment we can fix. This is a single missed character in the 2305 build system in one file.

In your build system, edit the file package/utils/usbmode/Makefile

Change line 68 from

> $(1)/etc/usb-mode.json

to

> $(1)/etc/usb-mode1.json

That's a single missing 1 that needs to be added.

This is happening because of the somewhat simpler way DM forks the original packages that need to be modified to make an OpenWRT a ROOter. DM's work provides a more up to date usb-mode.json, but we also need the usb-modeswitch package for functional reasons, and it comes with its own. DM has manually edited the Makefile of usb-modeswitch to put its old version at that usb-mode1.json location to make room for ROOter's. However, if he updates his package feed to fix a different problem, that change gets overwritten. It's easy to miss, then you get a bug like this.

We've had a lot of similar problems, but DM originally relied on some outside help to get these Makefiles set up (he's said flat out that's not where his best expertise lies), and I'm only learning enough now to start to understand how to do this the "right" way to make it easier to avoid these problems so I can help. If we do get into it it'll take a while to make all the changes but should make problems like this easier to avoid in the future and cut down on maintenance effort.

Thanks for helping spot this one!