search

ofnode / of

CMake openFrameworks for Linux, OS X and Windows.
71 stars 14 forks source link

aarch64 support #7

Open barzilouik opened 7 years ago

barzilouik commented 7 years ago

I read in the cmake that the architecture aarch64 (for pine64) is not supported. What would it take to make it compliant with such a board ?

avilleret commented 7 years ago

it seems that pine64 architecture is pretty similar to Raspberry Pi, so I guess there is no big issue with architecture. CMake should detect itself which arch you're building for but it is assumed in several part that arch is Raspberry Pi, so the main issue will be to find the right library which might not be in the same place as in Raspberry Pi. For example here is a RPi specific statement : https://github.com/ofnode/of/blob/master/CMakeLists.txt#L828-L833

avilleret commented 7 years ago

Concerning 64bit support for arm, this line https://github.com/ofnode/of/blob/master/CMakeLists.txt#L125 should be modified to deduce architecture bit from target architecture.

And concerning armv8 support, we should tweak some statement to either generalize armv7 specific command to other arm* or add armv8 specific statement (like compilation flag here https://github.com/ofnode/of/blob/master/CMakeLists.txt#L1031)

barzilouik commented 7 years ago

It seems to be more a concern with the #define TARGET_RASPBERRY_PI in OpenFrameworks : https://github.com/openframeworks/openFrameworks/search?q=TARGET_RASPBERRY_PI

It sounds like a hard task for adding on more board ...

avilleret commented 7 years ago

not sure because openframeworks build for generic armv7, which should work on armv8 too. for me the main concern is more 64 bit support (well you could still build 32bit instead).