Support lower .NET Framework version net451

oformaniuk / Handlebars.Net

A real .NET Handlebars engine

MIT License

3 stars 1 forks source link

Support lower .NET Framework version net451 #22

Closed StefH closed 4 years ago

StefH commented 4 years ago

Is it possible to support also support net40 and net451 for this library? I depend on version 451.

HandleBars.Net

The https://www.nuget.org/packages/Handlebars.Net/1.9.0 did only have .NETFramework 4.0 as minimum requirement.

Since 1.9.3, this is moved to .NETFramework 4.5.2.

oformaniuk commented 4 years ago

I already have problems supporting net452 (at least from language feature perspective) 😞 In any case I'd think on what can be done here 😉

oformaniuk commented 4 years ago

List of concerns at the moment:

Microsoft.Extensions.ObjectPool: the lowest supported version is netstandard1.3 which would require to bring polyfill for lower versions (or use custom pool implementation for all versions);
ExpressionShortcuts: need to bring support for lower versions here as well as it's heavily used and not possible to polyfill;
Originally my plan was to merge all the changes back to main repo and support for lower versions most probably would not be merged. However it looks like the chance of merging back is not really hight 😞

Once I get to my Windows workstation I’d be able to provide more on this.

StefH commented 4 years ago

I see. ( I did not know these two libraries yet... )

oformaniuk commented 4 years ago

@StefH I did some investigation and it seems that supporting net451 is possible (lower version would not fit in future plans). I would update ‘ExpressionShortcuts‘ to support is as well. However if you need it in Handlebars I’d kindly ask you to create a PR as I have other things planned. Acceptance criteria for the PR is to introduce thread-safe and fast ObjectPool implementation and use it as polyfill for net451.

StefH commented 4 years ago

I can take a look at ExpressionShortcuts
No need for polyfill, the ObjectPool version 1.1.1 already supports net451 : https://www.nuget.org/packages/Microsoft.Extensions.ObjectPool/1.1.1

oformaniuk commented 4 years ago

Yep, most probably I’ve missed it while was thinking more about net45 and lower 👍

Then the only thing needed is to add net451 as supported framework to Handlebars as I’ve already fixed ‘ExpressionShortcuts’.

StefH commented 4 years ago

https://github.com/zjklee/Handlebars.CSharp/pull/24