search

oframe / ogl

Minimal WebGL Library
https://oframe.github.io/ogl/examples
3.77k stars 213 forks source link

Package json update broke mocks for jest #160

Closed hansagames closed 1 year ago

hansagames commented 2 years ago

Hi, noticed that this update broke may jest based unit tests https://github.com/oframe/ogl/commit/363939c60d660f63928400faedb86370bce1d308

there main was removed and exports was added instead. Trying to investigate more but after this change I can not mock ogl model in jest based unit tests.

Any reason it was removed ?

Thanks you

hansagames commented 2 years ago

Ok found this https://github.com/oframe/ogl/pull/138 where it was discussed

hansagames commented 2 years ago

Looks like it was fixed in jest 28, but I still have 26 will check if can upgrade

gordonnl commented 1 year ago

Closing for now, but please let me know if there's a solution that works in junction with the discussion in #138 . As I said there, I'm happy to change if it works everywhere.