search

oframe / ogl

Minimal WebGL Library
https://oframe.github.io/ogl/examples
3.77k stars 213 forks source link

Source code in ts #213

Closed matiasngf closed 7 months ago

matiasngf commented 7 months ago

Hi! I noticed that the code is in JS and that there are hand-written declaration files. I was thinking in building a PR with a typescript version. I could try to do it in a way that allows for a smooth transition. Does it make sense?

pschroen commented 7 months ago

Hi Matias,

There was already a TypeScript version by @nshen a few years ago, and the declaration files are a combination of hand-written and automatically generated by @CodyJasonBennett and myself.

@gordonnl can chime in here as well, though currently there is no interest in transitioning the library to TypeScript. We're taking a similar approach as three.js where the library itself is vanilla JavaScript, that can run natively in the browser without any compiling or bundling needed.

Here's the previous TypeScript discussions and PR for reference:

matiasngf commented 7 months ago

Hi! make sense, thanks for the reply!