search

ofrohn / d3-celestial

A star map with d3.js
BSD 3-Clause "New" or "Revised" License
635 stars 181 forks source link

refactor to es6 module #141

Open alephpi opened 1 year ago

alephpi commented 1 year ago

hi, thanks for your excellent work! I am trying to play it with vue and make use of tree-shakable feature with es6 modules. do you plan to refactor it (as well as bump the d3 dependency to latest version)? i know it will cost much time, do you have an idea how to do it? maybe i'll start from src/celestial.js.

thank you!

alephpi commented 1 year ago

Hi, I'm looking into your source code now. I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

alephpi commented 1 year ago

Hi, I'm looking into your source code now. I wonder why here you divide by 1024 when compute the scale? Also, how did you get those 'magic' scale number for different projections? (e.g. aitoff scale is 162)

see comment here