search

ofrohn / d3-celestial

A star map with d3.js
BSD 3-Clause "New" or "Revised" License
632 stars 180 forks source link

masOS Safari not filling and stroking map's outline correctly #7

Closed JanisE closed 4 years ago

JanisE commented 6 years ago

What is Safari's problem when drawing the current sky by time and location?

context.fill in drawOutline seems to have no affect, and context.stroke seems to draw a broken circle:

http://storage5.static.itmages.com/i/18/0329/h_1522310479_5461621_65ecaba8c4.png

Tried with macOS Safari 10 and 11. On iPhone 8 it works all right though.

csibivili commented 4 years ago

experiencing the same issue...

https://trello-attachments.s3.amazonaws.com/5dd8184ccac55f7b03ea3343/1200x675/8b22bc3764f35159aef81c5e31f3e5ab/photo_2019-11-22_18.18.36.jpeg.jpg

alexandervlpl commented 4 years ago

Yeah, this is a problem. iOS Safari is not affected, desktop only.

knyazz commented 4 years ago

macOS Safari, the bug with the rendering of some projections: https://armchairastronautics.blogspot.com/p/skymap.html If we select some "...(hemi)" it renders something like that: https://cloud.mail.ru/public/5BXX/32rgUxKXr

ofrohn commented 4 years ago

I've finally been able to reproduce it. It also happens with other OSes, I'll get at soon...

ofrohn commented 4 years ago

That may have been easier than expected. I gave the background 179.9 degrees radius so that it wraps neatly around everywhere — and it seems to work! I think that could be called the nuclear option, but anyway, can anybody verify if the issue is fixed in the newest version? (0.6.20)

alexandervlpl commented 4 years ago

Nice hack. ;) This works for me on Safari, I tried many projections. Is there a chance that a 0.1° white sliver will now be visible on some high-res monitors? I don't see anything myself.

@ofrohn thanks for your work on this! Any way to contribute to development or buy you a beer?

ofrohn commented 4 years ago

@alexandervlpl Thank you! I don't require any liquid fertilizer to work, but if you have any errors to report or feature ideas, you are always welcome! See the road map here: https://github.com/ofrohn/d3-celestial/wiki/Roadmap

The background is always centered before displaying, so the missing sliver should always be outside the clipped hemisphere.