search

ogaclejapan / SmartTabLayout

A custom ViewPager title strip which gives continuous feedback to the user when scrolling
Apache License 2.0
7.09k stars 1.34k forks source link

Need removeOnPageChangeListener #208

Open blaine0611 opened 7 years ago

blaine0611 commented 7 years ago

I noticed that this component did not have removeOnPageChangeListener() method. Is there any ways to remove listener?

blaine0611 commented 7 years ago

here in the line 321

public void setViewPager(ViewPager viewPager) {
    tabStrip.removeAllViews();
    this.viewPager = viewPager;
    if (viewPager != null && viewPager.getAdapter() != null) {
      viewPager.addOnPageChangeListener(new InternalViewPagerListener());
      populateTabStrip();
    }
}

If i did smartTabLayout.setViewPager(viewPager); twice, onPageSelected() would be called twice. I guess before viewPager.addOnPageChangeListener(new InternalViewPagerListener()); , we should call viewPager.clearOnPageChangeListener() first?