Migrate to AndroidX - Githubissues

ogaclejapan / SmartTabLayout

A custom ViewPager title strip which gives continuous feedback to the user when scrolling

Apache License 2.0

7.09k stars 1.34k forks source link

Migrate to AndroidX #271

Closed ezamelczykespeo closed 5 years ago

ezamelczykespeo commented 5 years ago

As of right now there are problems with working with this library with AndroidX. I suggest migrating to AndroidX namespace.

ogaclejapan commented 5 years ago

Thank you for your reporting. I'm planning to v2.0 version for AndroidX

davideas commented 5 years ago

Please, just support the AndroidX without new features... for now. Create v1.7.0. It should take 30-60 mins.

thisisnova commented 5 years ago

It's working fine in my app after migrating to AndroidX although android studio shows me warning about wrong arguments.for example:

'setOnPageChangeListener(android.support.v4.view.ViewPager.OnPageChangeListener)' in 'com.ogaclejapan.smarttablayout.SmartTabLayout' cannot be applied to '(androidx.viewpager.widget.ViewPager.OnPageChangeListener)'

herberthobregon commented 5 years ago

download this and add as module

https://github.com/Sanchit43/SmartTabLayout

ogaclejapan commented 5 years ago

SmartTabLayout migrated to androidx. Sorry for replying so late 🙏