Peer to Peer Code Review

[trace-kadenyi]

Hi Esi, I'm @TracK92 and I will be reviewing your code today 😄. Firstly, you did a remarkable job on this project. You should be very proud of yourself dev Esi 😊

Highlights ✅

• [x] Neat, professional work
• [x] No linter errors.
• [x] Proper implementation of JavaScript, HTML and CSS best practices
• [x] I really your background image and how it aligns with the content of the page 💯

Issues ❎

Kindly observe the following issues to enhance your code.

• [ ] The menu bar on your About page is not functional. Kindly enable this functionality to allow users on smaller screens to view your menu options. I suggest that you use JavaScript for the display of the menu options.

• [ ] The cards in the Main Program section of your Home page are not uniform in height for all screen sizes. The last card, in particular, gets shorter than the rest as the screen is adjusted. Kindly make them the same height for all screen sizes as it makes the UI look more professional and enhances UX.

• [ ] Want to know what would make your code even better? Consider adding the More option for your speaks section. It would be great JavaScript practice for you as well.

• [ ] Lastly, I recommend using inline comments in your code to enhance readability. This would make your work more professional and make you easy to work with during pair programming projects.

const mobileMenu = () => {
  hamburger.classList.toggle('active');
  if (hamburger.classList.contains('active')) {
    hamburger.innerHTML = '<i class="fas fa-times"  style="color:#fff"></i>';
  } else { hamburger.innerHTML = '<i class="fas fa-bars style="color:#fff"></i>'; }
  navMenu.classList.toggle('active');
};

const closeMenu = () => {
  hamburger.innerHTML = "<i class='fas fa-bars' ></i>";
  navMenu.classList.remove('active');
  hamburger.classList.remove('active');
};

[ogagaoghene]

Okay thanks