search

ogagaoghene / recipe_app

A Recipe app that keeps track of all your recipes, ingredients, and inventory and allow users save ingredients, keep track of what is in stock, create recipes, and generate a shopping list based on what is in stock and what is missing from a recipe. It also has authorization features. Built with Ruby on Rails.
5 stars 0 forks source link

Setup Kanban board #5

Closed ogagaoghene closed 1 year ago

ogagaoghene commented 1 year ago

The link to thE gItHub KanBan board https://github.com/users/ogagaoghene/projects/7 https://github.com/users/ogagaoghene/projects/7

I am the only one assigned to this Group Project. I have been asked to let the reviewer know about this. Please find below screenshots of the conversations I had with a representative of Microverse that advised that I take a screenshot of our conversation.

image image

The link to thE gItHub KanBan board https://github.com/users/ogagaoghene/projects/7 https://github.com/users/ogagaoghene/projects/7

prolajumokeoni commented 1 year ago

Hi @ogagaoghene

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not have a link to your GitHub project(kanban board)

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @ogagaoghene,

Good job so far! ✔️ Good documentation However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 1 year ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @ogagaoghene,

Good job so far! ✔️ Good documentation However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ogagaoghene commented 1 year ago

@TedLivist I am the only one in my team. Attached in this issue request is my correspondence with a staff of Microverse. She asked I make this known to you. Don't you think it will be fair that specific requirements be assigned to me. I saw the list of requirements that you have attached. Kindly advise and be discretional as I am the only one in my team. I look forward to hearing from you so I can initiate the next step.

ogagaoghene commented 1 year ago

@TedLivist The screenshoted list of requirements is for a team of 3 members. Kindly specify what is appropriate for me as advised by the staff of Microverse. That's what is fair

sja-thedude commented 1 year ago

Required Changes ♻️

Hi @ogagaoghene, This is @sja-thedude your code reviewer.

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

200w

Highlights

✔️ Good job so far

Required Changes ♻️

https://user-images.githubusercontent.com/70269507/203099956-39323a9b-f9c1-4b12-8d09-0b31ffa11da9.mov

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

danmainah commented 1 year ago

Hi @ogagaoghene ,

Great work on making the changes requested by a previous reviewer 👏 👏 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

✔️ Good documentation ✔️ Good descriptions

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ogagaoghene commented 1 year ago

@danmainah I have exhaused all reviews. How can I request for an extra review. You should have optionally mentioned this bro. That is what is expected.

danmainah commented 1 year ago

@danmainah I have exhaused all reviews. How can I request an extra review. You should have optionally mention this bro. That is what is expected.

I understand the frustration but I cannot approve it if all requirements are not met , kindly ask for second opinion if you differ with my review, all the best

ogagaoghene commented 1 year ago

@danmainah It is okay. How can I request for an extra review. I have done what you asked that I should do

danmainah commented 1 year ago

kindly check on the dashboard, it should offer you option to use the extra reviews

ogagaoghene commented 1 year ago

@danmainah I have made the request. Thanks

danmainah commented 1 year ago

Hi @ogagaoghene ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉

Highlights

✔️ Good documentation ✔️ Good descriptions

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ogagaoghene commented 1 year ago

@danmainah Thank you

ogagaoghene commented 1 year ago

Fully resolved and implemented