search

oganm / homologene

:mouse: :left_right_arrow: :couple: An r package that works as a wrapper to homologene
https://oganm.github.io/homologene/
Other
42 stars 4 forks source link

Do not detach packages in your tests #13

Closed jimhester closed 5 years ago

jimhester commented 5 years ago

There is as far as I can tell, no need for this test, you are not doing anything in .onLoad or .onAttach that would change the behavior.

Fixes https://github.com/r-lib/covr/issues/346

codecov-io commented 5 years ago

Codecov Report

Merging #13 into master will increase coverage by 10.93%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
+ Coverage      50%   60.93%   +10.93%     
===========================================
  Files           5        5               
  Lines         192      192               
===========================================
+ Hits           96      117       +21     
+ Misses         96       75       -21
Impacted Files Coverage Δ
R/diopt.R 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37ba5ae...8de5728. Read the comment docs.

oganm commented 5 years ago

Ah I see thanks a lot. I had that test because I didn't properly call the dataset in an earlier iteration, causing it to fail when detached. Shouldn't be necessary as long as I do things right