search

ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
327 stars 144 forks source link

Cell protection against occassional overwrtie #124

Closed pan64 closed 2 years ago

pan64 commented 3 years ago

solves issue #14

ogarcia commented 3 years ago

Thanks for this pull request!

I think that's better ask for overwrite than simply lock the entry, because if you have a mistake you must enter settings, disable option, perform modify, go settings and enable again.

pan64 commented 3 years ago

Hi, what do you think. It should work only in SingleNumber input mode (or independently, for every IM)?

Thanks

On Sat, Jun 26, 2021 at 7:07 PM Óscar García Amor <

wrote:

Preview: Thanks for this pull request! I think that's better ask for o --> SPAM? CLICK to BLOCK @.***/>

This email is Masked using Blur - it was sent from github.com to @.*** (your reply stays Masked). To protect your privacy https://www.abine.com/faq.html#caniaddcc, do not forward this message, or add new recipients like CCs or BCCs.

Thanks for being a Blur customer! If you haven't yet, [ Try DeleteMe at a discount. https://joindeleteme.com/?utm_source=blur&utm_medium=email&utm_campaign=blur-offer ]

Thanks for this pull request!

I think that's better ask for overwrite than simply lock the entry, because if you have a mistake you must enter settings, disable option, perform modify, go settings and enable again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/pull/124#issuecomment-869031005, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXX3UYXOFHXK6L7WTOTFNDTUYCN5ANCNFSM47LOBZWQ .

ogarcia commented 3 years ago

I think, for consistency, that is better in every entry mode

ogarcia commented 2 years ago

I'm migrating Open Sudoku development from GitHub to GitLab. To make the migration as clean as possible I'm going to close this PR. If you are still interested in it, please open it again in GitLab following the contributing guide.

Thank you very much for your understanding.