ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

adding additional puzzles resp. links to more puzzles #21

Closed DJCrashdummy closed 6 years ago

DJCrashdummy commented 6 years ago

beforehand: thank you sooo much for bringing this awesome project back to life!!!

i know, there is a generator at the homepage (kudos for that!)... but how about some additional links to static collections (like at the original project) for easily adding the same big collections on several devices? beside the original project's collection, https://opensudoku.p43.eu/ is really worth mentioning, and also at http://www.sudocue.net/download.php some collections can be found.

may these also be added also to the readme and the store-descriptions...?

ogarcia commented 6 years ago

Hi @DJCrashdummy

In the original project are same files that in http://opensudoku.moire.org/ (The Easy, Medium, Hard and Very Hard puzzles). But I can add a link to https://opensudoku.p43.eu/ in the list. In http://www.sudocue.net/download.php cannot find any .opensudoku file. I cannot add links that not have files that can be added easy to game. Take note that we have non tecnical users.

ogarcia commented 6 years ago

Added P43 link into http://opensudoku.moire.org/ page.

DJCrashdummy commented 6 years ago

@ogarcia thanks for adding https://opensudoku.p43.eu/ to (at least) the homepage, but i see no reason for the hint (The first list of gnome-sudoku/opensudoku files), because .sdm-files can be added in the same way as .opensudoku-files.

ogarcia commented 6 years ago

@DJCrashdummy the hint was incomplete :-D ¡Fixed!

DJCrashdummy commented 6 years ago

sorry for bothering you with this... but for me importing sdm-files work exactly the same way as opensudoku-files, so also by opening the file via a file manager with Open Sudoku the file gets imported. therefore i see no reason to complicate things (even not explanations) for non-techy users... :confused:

ogarcia commented 6 years ago

.opensudoku files can be imported directly from browser window but if you try to open .sdm files directly with Open Sudoku the process fail. You must download first the file. That is the reason of the hint.

DJCrashdummy commented 6 years ago

ok... now i got you! :wink:

i promise my last suggestion concerning this topic... why not use a more precise wording (since for example both files have to be "downloaded" - and i also experience every now and then confusion at my noobs with eventual differences in opening/importing): The first list of gnome-sudoku/opensudoku files can be openend imported directly by the OpenSudoku app, the second one must be downloaded saved to the device and imported by hand either opening it with the OpenSudoku app or using the import option in the app menu.

ogarcia commented 6 years ago

Done!

chrisawad commented 4 years ago

Btw, the generated files on the website are .opensudoku.xml. We have to rename the file and remove .xml to get it to import.

Can you either add xml extension to the intent filters or fix the website to generate without xml extension?

Also it would be awesome to add a generate button in game or import from online option that downloads from the link without leaving the game. I would love this feature as solving the 20 very hard puzzles for me is cake and I'm having to revisit the site a million times.

ogarcia commented 4 years ago

@chrisawad the generated files in website are .opensudoku. I don't know if your browser is adding the .xml extension. Please try with Chrome or Firefox.

DJCrashdummy commented 4 years ago

i can confirm, that downloading one of the generated files with firefox or chromium (no matter if desktop or android) gives you a .opensudoku file.

chrisawad commented 4 years ago

@chrisawad the generated files in website are .opensudoku. I don't know if your browser is adding the .xml extension. Please try with Chrome or Firefox.

Interesting. I just tried it on Chrome for desktop and it didn't add .xml. Chrome for Android on the other hand, always adds .xml. Considering this is an Android app and the link in the app opens for most people in Chrome for Android, they'll all face what I have to face every time I go to download more generated puzzles (open in Files app, remove .xml, then go back to the app).

I took a look at the code -- it should be pretty simple to pass the URI for the very hard generate link directly to OpenSudokuImportTask to avoid having to visit the website, right?

As someone who plays 5-10 very hard puzzles a day and having to go through this .xml renaming process just to get 20 new puzzels, this gets very annoying.

Do we know if the puzzle generation logic on the website can be incorporated directly into the app? This too would skyrocket the usefulness of the app, with unlimited puzzles.

chrisawad commented 4 years ago

94 started adding a generator pull request