search

ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

Puzzle solver #35

Closed steve3424 closed 5 years ago

ogarcia commented 5 years ago

Hi Steve,

This is a great contribution, but please change your pull request to develop branch.

The only problem that I have now is that cannot upload changes to Google Play Store because first for all I must fix #30 and I not have time to do it. If you want help on these issue you are welcomed.

Thanks again for your first contribution :wink:

steve3424 commented 5 years ago

Thanks for the feedback. I will definitely look into that issue and I will change this pull request.

steve3424 commented 5 years ago

Hey Oscar, I was wondering if you had any trouble with the develop branch. I want to look into issue #30, but I can't get the code from the develop branch to run on my emulator. I have played around and it has something to do with the 'android:theme' in the manifest, but I can't find a fix. Were you able to run the code without issue?

Thanks, Steve

On Mon, Aug 26, 2019 at 2:45 AM Óscar García Amor notifications@github.com wrote:

Hi Steve,

This is a great contribution, but please change your pull request to develop branch.

The only problem that I have now is that cannot upload changes to Google Play Store because first for all I must fix #30 https://github.com/ogarcia/opensudoku/issues/30 and I not have time to do it. If you want help on these issue you are welcomed.

Thanks again for your first contribution 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/pull/35?email_source=notifications&email_token=AHKQ5CQHS5SUQNMF5ZHVPYLQGN3XZA5CNFSM4IPERFEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DN4LI#issuecomment-524738093, or mute the thread https://github.com/notifications/unsubscribe-auth/AHKQ5CX4IH7MT2V2ZKMLHK3QGN3XZANCNFSM4IPERFEA .

ogarcia commented 5 years ago

Hi Steve,

Develop branch is, well, a develop branch. I remember when I merge #29 that it worked in emulator with old versions of Android (for example 4, or 5) but in new versions (from 6.0 onwards) it don't work cause of #30. The code lacks the permissions requesting and cannot be executed.

steve3424 commented 5 years ago

Hey Oscar,

Ok haha I understand. I was under the impression that the latest code was working it just didn’t ask for the permission. So I was thinking I had something wrong on my end. Thanks for the info I appreciate it!

Steve

On Aug 29, 2019, at 3:04 AM, Óscar García Amor notifications@github.com wrote:

Hi Steve,

Develop branch is, well, a develop branch. I remember when I merge #29 that it worked in emulator with old versions of Android (for example 4, or 5) but in new versions (from 6.0 onwards) it don't work cause of #30. The code lacks the permissions requesting and cannot be executed.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.