search

ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

Fix issue #30 + other fixes #37

Closed steve3424 closed 5 years ago

steve3424 commented 5 years ago

I was having trouble with the latest commits of the develop branch. It had something to do with the theme. I changed the theme and changed 2 of the ListActivity classes to AppCompatActivity classes. It is now working as far as I can tell. There are still a few issues that I am working on.

steve3424 commented 5 years ago

I just added the permission requests needed to fix issue #30

I believe the transition from ListActivity to AppCompatActivity caused a new issue where the context menu isn't working, but I will look into this.

steve3424 commented 5 years ago

fixed

steve3424 commented 5 years ago

fixed problem where the pop up keyboard was causing app to crash

steve3424 commented 5 years ago

added solver feature

ogarcia commented 5 years ago

Great work! Tell me when you finish this pull request to merge it. And add you in Contributors section of README :wink:

steve3424 commented 5 years ago

Thanks! It is finished now. Are you able to put this on Google Play store now?

On Sep 6, 2019, at 5:41 AM, Óscar García Amor notifications@github.com wrote:

Great work! Tell me when you finish this pull request to merge it. And add you in Contributors section of README 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ogarcia commented 5 years ago

Thanks! It is finished now. Are you able to put this on Google Play store now?

I think yes. But I'm AFK until next weekend. At these moment I'll do the tests and upload it.

steve3424 commented 5 years ago

Great! Let me know if there are any problems.

Also when I first read your message I read it as saying that I was supposed to add my self to the README so I did. Then I re-read it and i think you were saying you will do that right?

On Sep 6, 2019, at 3:12 PM, Óscar García Amor notifications@github.com wrote:

Thanks! It is finished now. Are you able to put this on Google Play store now?

I think yes. But I'm AFK until next weekend. At these moment I'll do the tests and upload it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ogarcia commented 5 years ago

No, you can do it. I think that this commit is perfect.

steve3424 commented 5 years ago

Ok great I will put that commit up

On Sep 6, 2019, at 3:12 PM, Óscar García Amor notifications@github.com wrote:

Thanks! It is finished now. Are you able to put this on Google Play store now?

I think yes. But I'm AFK until next weekend. At these moment I'll do the tests and upload it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ogarcia commented 5 years ago

Hi Steve, I can merge this PR, but I found a small issue, if you put a wrong number in a cell and try to use solver, nothing happens. I think that when solver cannot solve the puzzle (because some is wrong) it must display a warning message. Another issue is that if you finish a puzzle and press restart option, the solver option remains deactivated. You must exit and enter again to use option.

Tell me what do you do. You prefer fix this issues now or want to merge this pull request and open a new one in the future?

steve3424 commented 5 years ago

Thanks for letting me know. I will look this afternoon and send you an email tonight if that’s ok.

On Sep 23, 2019, at 9:35 AM, Óscar García Amor notifications@github.com wrote:

Hi Steve, I can merge this PR, but I found a small issue, if you put a wrong number in a cell and try to use solver, nothing happens. I think that when solver cannot solve the puzzle (because some is wrong) it must display a warning message. Another issue is that if you finish a puzzle and press restart option, the solver option remains deactivated. You must exit and enter again to use option.

Tell me what do you do. You prefer fix this issues now or want to merge this pull request and open a new one in the future?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

steve3424 commented 5 years ago

Fixed both issues. If there are any others you find let me know.