ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

Title screen and "resume" feature #56

Closed jlnordin closed 4 years ago

jlnordin commented 4 years ago

This PR adds a title screen as the primary launcher activity to Open Sudoku with a new "resume" feature to start the most recently played game. I find this very helpful to avoid clicking through 2-4 screens to pick up where I left off.

I also moved the "what's new" dialog to the title screen activity since this is intended to be the landing page for all app launches now.

Title Screen

Scenarios Tested

jlnordin commented 4 years ago

Note that this PR will conflict with the note highlighting PR since they both add strings. Whichever PR is accepted first, I'll be sure to fix the merge conflicts of the other one.

ogarcia commented 4 years ago

Merged! Tell me when you want make a new play store version :wink:

jlnordin commented 4 years ago

I'd say now is a good time for a new version in the store. :-)

On Mon, Feb 3, 2020 at 12:25 AM Óscar García Amor notifications@github.com wrote:

Merged! Tell me when you want make a new play store version 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/pull/56?email_source=notifications&email_token=AOETRWBZ6OU34SBWFVI6ZI3RA7IGJA5CNFSM4KOYIGOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKS5GXA#issuecomment-581292892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOETRWCZ2EOCNKZYAA2VNMLRA7IGJANCNFSM4KOYIGOA .

jlnordin commented 4 years ago

Oscar, when you upload the next version, would it be possible to update some of the screen shots on the play store with some of the new themes?

Thanks!

On Mon, Feb 3, 2020, 3:58 AM Justin Nordin jlnordin@gmail.com wrote:

I'd say now is a good time for a new version in the store. :-)

On Mon, Feb 3, 2020 at 12:25 AM Óscar García Amor < notifications@github.com> wrote:

Merged! Tell me when you want make a new play store version 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/pull/56?email_source=notifications&email_token=AOETRWBZ6OU34SBWFVI6ZI3RA7IGJA5CNFSM4KOYIGOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKS5GXA#issuecomment-581292892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOETRWCZ2EOCNKZYAA2VNMLRA7IGJANCNFSM4KOYIGOA .

ogarcia commented 4 years ago

Yes, no problem. ;-)

Porrumentzio commented 4 years ago

I don't know whether to create a new issue or post my comment here.

This feature is great, but I have a improvement to it: hide this button when the last sudoku was resolved!