ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

Remove notes on number entry #61

Closed jlnordin closed 4 years ago

jlnordin commented 4 years ago

This PR adds a feature to automatically remove all the notes in the same column, row, and box when entering a number in a cell. This can be disabled in settings and is off by default. This addresses feature request #31 .

If you use this feature, both the number entry and all the note removals are grouped together into the same command so that you can undo the entire operation as a logical unit.

This PR also adds a new abstract base class -- AbstractMultiNoteCommand -- to centralize some of the common behavior between FillInNotesCommand, ClearAllNotesCommand, and the new SetCellValueAndRemoveNotesCommand.

Scenarios Tested

ogarcia commented 4 years ago

Sorry for delay, along this week I'll merge and upload new version :wink: