ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
327 stars 144 forks source link

Add option to skip titlescreen, fix hint crash, fix custom themes bug #66

Closed jlnordin closed 4 years ago

jlnordin commented 4 years ago

This PR addresses issues #65, #64, and #62 by fixing a few bugs and adding a feature to skip the new title screen and launch directly on the Sudoku list screen.

Skip Titlescreen

Per user feedback, this PR adds a new option "Show sudoku lists on startup" that will launch the app directly to the sudoku lists screen on startup. The title screen will still be accessible via back navigation, but the app will start on the lists activity.

Hint Crash

If you used the "hint" command from the options menu when no cell was selected, the activity would crash. This PR adds a null check to make sure the "couldn't show hint" dialog is shown instead.

Sudoku Preview Colors in Folder View

If you are using a custom theme instead of a built-in theme, the sudoku previews that are shown in the folder views were always black-and-white. This PR changes it to reflect the current custom theme colors.

Scenarios Tested

jlnordin commented 4 years ago

Note: I can split this into 3 different PRs if needed. I kept this as one PR just to save some time when merging in later.

ogarcia commented 4 years ago

Merged! Many thanks for the fixes!