ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
328 stars 144 forks source link

Bidirectional selection enabled despite turned off in settings #71

Closed slowan closed 2 years ago

slowan commented 4 years ago

When field is selected (no matter if editable or not) the corresponding button is highlighted despite the setting is off. Screenshot_20200328-141249_Open Sudoku Screenshot_20200328-141401_Open Sudoku Screenshot_20200328-141300_Open Sudoku Screenshot_20200328-141310_Open Sudoku

slowan commented 4 years ago

It is quite annoying as it looks similar to greyed button for numbers present more than 9 times.

jlnordin commented 4 years ago

Slowan,

That option only applies to single number input mode -- num pad mode will always show the current number because that's how that input mode works. It will show the current state of the number or the notes (if notes mode is active).

Can you describe how you expect it to work? If so, we might be able to add a feature to make it work better for you.

As for the colors, I added them in and tried to make the contrast between highlighted numbers and completed numbers as clear as possible, but some themes are clearer than others. If you want to make the distinction clearer on your own game you can create a custom theme based on the open Sudoku theme and change the button highlight color to whatever you like.

On Sat, Mar 28, 2020, 6:17 AM slowan notifications@github.com wrote:

It is quite annoying as it looks similar to greyed button for numbers present more than 9 times.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/issues/71#issuecomment-605446303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOETRWE2JD6RJZ2MG5Z6DYDRJX2HXANCNFSM4LVSIGTQ .

ogarcia commented 2 years ago

I'm migrating Open Sudoku development from GitHub to GitLab. To make the migration as clean as possible I'm going to close this issue. If you are still interested (or if it is still relevant), please open it again in GitLab from July 26.

Thank you very much for your understanding.