Note screen colors

[cskaryd]

Could you change (or add an option to change) the color of the selected notes? To my color blind eyes it is very hard to distinguish between selected numbers and deselected numbers.

[spimanov]

Hi! I have just unintentionally found this message. Not sure that it's still actual, but I guess it's possible to add the such kind of functionality. Will do it

[cskaryd]

I tried to make this change myself, but haven't had any experience with Android development. The white and cyan are just so close for my eyes that it's incredibly hard to determine which numbers are selected on the note screen.

Thanks for taking a look! I look forward to the diff to see how you do it.

On Feb 15, 2018 5:07 PM, "Sergey Pimanov" notifications@github.com wrote:

Hi! I have just unintentionally found this message. Not sure that it's still actual, but I guess it's possible to add the such kind of functionality. Will do it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ogarcia/opensudoku/issues/8#issuecomment-366077569, or mute the thread https://github.com/notifications/unsubscribe-auth/AFa50mngNtU5JBoMte9du_r5uoQEcTCbks5tVKqIgaJpZM4QjDZd .

[spimanov]

Hello guys! Let's check it. I've sent a pull-request: Custom theme settings @ogarcia I would suggest to modify existing themes - they are almost similar.

[ogarcia]

Thanks @spimanov is a great change!

I will merge it now and make small changes into themes, If you have ideas for new themes they are welcomed.

[ogarcia]

Published new version 2.5.0 in Play Store with changes. I make small modifications in existing themes, but they are thinked only to show what do you change. Basically the themes are the same but with inverted colors.

@spimanov a posible enhancement could be add a text color setting for secondary, touched, selected and highlighted cell (or only for selected and highlighted).

@opalCSkaryd I add a high contrast theme to color blind people. What do you think about it?

[cskaryd]

Hi @ogarcia -

Unless I'm missing an option, I don't see the change. Or perhaps I needed to be more specific regarding the issue. The lines at the bottom of the buttons for #s 5 and 6 as shown here is what I was referring to. 5 is unselected, where 6 is selected. Is there a way to set the color scheme for that 1 pixel line at the bottom of the Edit Note number button?

Thanks!

[ogarcia]

@opalCSkaryd the main problem about this is that the button desing is a part of Android system.

To change interface colors that the app must be rewrited and (I think) this broke the old android version support.

I suggest you to use other input method as NUM PAD and see the anotations directly in board.

[ogarcia]

The original issue is fixed now. I created #41 to follow app theme enhancement