ogarcia / opensudoku

Open Source Sudoku game for Android.
GNU General Public License v3.0
327 stars 144 forks source link

Basque Strings not updated on v3.5.0 #99

Closed Porrumentzio closed 4 years ago

Porrumentzio commented 4 years ago

I made the whole translation for Basque but on update to v3.5.0 on F-Droid, some strings are not translated, concretly those of game level: Easy, Mediumand Hard.

Those strings are these: https://github.com/ogarcia/opensudoku/blob/78dee8123d504736059748591e80fa78505b1540/app/src/main/res/values-eu/strings.xml#L264 https://github.com/ogarcia/opensudoku/blob/78dee8123d504736059748591e80fa78505b1540/app/src/main/res/values-eu/strings.xml#L265 https://github.com/ogarcia/opensudoku/blob/78dee8123d504736059748591e80fa78505b1540/app/src/main/res/values-eu/strings.xml#L266

What happened with those strings? All other strings are translated.

ogarcia commented 4 years ago

These strings are well translated. But only works in a new installation (or if you clean app storage) because the Easy, Medium and Hard are folders and you could have renamed them.

Porrumentzio commented 4 years ago

Okay, I understand. I'm closing this issue, thanks :)

If I clean app storage I'll loose my done sudokus' times and so on, right?

ogarcia commented 4 years ago

If I clean app storage I'll loose my done sudokus' times and so on, right?

Yes. Is like a new install. I think that is better that you rename folders by hand and test in other device :wink:

Porrumentzio commented 4 years ago

I don't find the folders. Anyway, what do you think about letting the app change the folder names according to the translation? In a case of updating or changing the device locales.

Is it very difficult to implement?

ogarcia commented 4 years ago

The app behabiour is:

If you want change the folders name, long press in one of them and select, change folder name.

Porrumentzio commented 4 years ago

Understood now, I didn't know about the ability to rename folders