search

ogcio / ogcio-ds

MIT License
4 stars 0 forks source link

feat: add table component #28

Closed anapaulalemos closed 1 year ago

anapaulalemos commented 1 year ago

Ps: getNodeFormattedInnerHtml didn't work with the table 😞, it turned it all into one big string:

Screen Shot 2022-11-23 at 11 25 04
denes-fekeshazy commented 1 year ago

Looks good. One small suggestion is that rather than leaving comments for where a section of the component start, you could pull those out into a separate function like createTableHeader() and then use those in the Template. Then again I have probably create long Template functions as well, so feel free to ignore this.