search

ogdenwebb / emacs-kaolin-themes

Set of eye pleasing themes for GNU Emacs. Supports both GUI and terminal.
GNU General Public License v3.0
731 stars 28 forks source link

Rework magit faces #18

Open ogdenwebb opened 5 years ago

ogdenwebb commented 5 years ago

Another thing I notice is in magit log, color changes between hunks are easier to read in light theme than in dark theme. Not quite a bug, but perhaps you might want to take a look too?

output-2019-03-22-10:17:41

Originally posted by @yiufung in https://github.com/ogdenwebb/emacs-kaolin-themes/issues/17#issuecomment-475471157

trev-dev commented 2 years ago

A nit-picky thing from me on this issue, too, is the caret that denotes an open/closed drawer is smooshed, too.

ogdenwebb commented 2 years ago

@trev-dev hello. Please would you provide an example with this particular part to clarify your issue?

trev-dev commented 2 years ago

@ogdenwebb Sure! Here's a gif of me opening/closing magit "drawers". You can see the caret on the left. This is not unique to Kaolin and the easiest solution would be to make their color the same as the background.

kaolin-magit

ogdenwebb commented 2 years ago

@trev-dev looks like magit doesn't have its own faces for fringe (this area where you see these indicators) and use default fringe faces instead, so I can not modify this area [without custom workaround]. I think you could open an issue in the magit repository if you really need that.