ogdenwebb / emacs-kaolin-themes

Set of eye pleasing themes for GNU Emacs. Supports both GUI and terminal.
GNU General Public License v3.0
744 stars 27 forks source link

Trouble making default #20

Closed Jesse415 closed 5 years ago

Jesse415 commented 5 years ago

in my .spacemacs dot file I have under dotspacemacs-additional-packages '(kaolin-themes). spc T s I can choose kaolin-bubblegum but to try to make it default under dotspacemacs-themes '(kaolin-bubblegum) it will not load. I saw the quick start settings and tried to up it under dotspacemacs-themes '() but also no go. I'm not sure where I am going wrong, please help. Also, awesome themes!

ogdenwebb commented 5 years ago

Hi, @Jesse415! This issue is related to Spacemacs. Alas, I'm vanilla (well, with evil) Emacs user, so I can't figure out how to fix that in Spacemacs right now. AFAIK, Spacemacs adds some extra spices on top of the load-theme feature. I'll look into this issue a bit later.

Meanwhile, as a temporary workaround you can try the following.

;; Add kaolin-themes to dotspacemacs-additional-packages in your spacemacs config
   dotspacemacs-additional-packages '(kaolin-themes)
;; Keep your dotspacemacs-themes by default
   dotspacemacs-themes '(spacemacs-dark
                         spacemacs-light)

;; Finally load theme after loading spacemacs
(defun dotspacemacs/user-config ()
  "Configuration function for user code.
This function is called at the very end of Spacemacs initialization after
layers configuration.
..."
  (spacemacs/load-theme 'kaolin-bubblegum)
  )
ogdenwebb commented 5 years ago

Well, that will be fixed with https://github.com/syl20bnr/spacemacs/pull/12386.

duianto commented 5 years ago

The PR: Add more Kaolin themes to spacemacs-theme-name-to-package. https://github.com/syl20bnr/spacemacs/pull/12386 is now on the Spacemacs develop branch.

ogdenwebb commented 5 years ago

Please notice me if you have any other problems with this package. I guess I can close the issue now.

Jesse415 commented 5 years ago

Thank you, I will let you know