ogdenwebb / emacs-kaolin-themes

Set of eye pleasing themes for GNU Emacs. Supports both GUI and terminal.
GNU General Public License v3.0
744 stars 27 forks source link

Kaolin themes are broken for terminal #35

Closed ayrat555 closed 4 years ago

ayrat555 commented 4 years ago

I'm getting

emacs *error*: undefined color: "brightblack"

If I start emacs in terminal mode. I run it as a daemon.

ogdenwebb commented 4 years ago

Please provide more information about this issue.

  1. Terminal type/name.
  2. Does it appear with all themes or only some of kaolin-themes?
  3. Do you use Spacemacs?
  4. Does Emacs without emacsclient work as expected?
ogdenwebb commented 4 years ago

Also please paste the output with debug-on-error enabled.

ayrat555 commented 4 years ago

Terminal type/name.

zsh / tilix

Does it appear with all themes or only some of kaolin-themes?

It appears with some themes (kaolin included). It doesn't appear with nord theme It seems they fixed similar issue in nord https://github.com/arcticicestudio/nord-emacs/issues/59

Do you use Spacemacs?

No

Does Emacs without emacsclient work as expected?

It works ok in GUI mode. I use emacs only in daemon mode

ogdenwebb commented 4 years ago

Currently I'm not even sure what causes the problem, because I can't reproduce this issue by myself. Can you give me a scenario to reproduce this issue? Including your OS, Emacs version, how you start daemon, echo your $TERM and etc.

Also please paste the output with debug-on-error enabled. Does it appears with doom-themes for you too?

Does it appears if you run kaolin-themes like this:

(add-hook 'after-make-frame-functions
          (lambda (_frame)
            (load-theme 'kaolin-dark t)))

I'm using emacs --daemon too, I put it in my awesomewm autostart.lua file, but I've never met something like that on Linux with Emacs 25-26.

ayrat555 commented 4 years ago

@ogdenwebb I upgraded to emacs 26.3. Now it seems to be working

I see

Emacs now supports 24-bit true color on text terminals which provide that feature. See Colors on a TTY.

in https://www.gnu.org/software/emacs/manual/html_node/efaq/New-in-Emacs-26.html Maybe it was related

Thanks anyway