search

ogdenwebb / emacs-kaolin-themes

Set of eye pleasing themes for GNU Emacs. Supports both GUI and terminal.
GNU General Public License v3.0
744 stars 27 forks source link

Dark on dark text in vterm #46

Closed mplanchard closed 3 years ago

mplanchard commented 3 years ago

Errors from cargo build have a lot of helper text, including line numbers and arrows to point out where issues are. I've seen similar dark on dark text using ava for javascript projects.

These show up as white text on a dark background using the kaolin themes in both term and eshell, but in vterm they show up as dark text on a dark background. Examples below in kaolin-temple, but it applies to all of the kaolin themes I've tested:

in term:

image

but in vterm:

image

I get the same thing on both mac and windows, running emacs 27.1.

In other themes, these arrows are often brightly colored in vterm, for example (in doom/dark+):

image

Screenshots captured using emacs-kaolin-themes 821174031219dedd35c06a99c4a9f8d619c95f8c

I don't know much about theming. I'm still trying to dig into this, but any help would be appreciated!

ogdenwebb commented 3 years ago

Hello. This bug appears due to missing vterm faces, and I've added them. Currently I have to API to manage all 16 colors, so color number 1 and color number 9 is the same red color for example, but at least you can see those arrows and etc now. :)

Please let me know if it works for you.

mplanchard commented 3 years ago

Thanks for the quick reply and fix! I'll update today and report back.

mplanchard commented 3 years ago

It looks great now, thanks so much! I'll close the issue.

image