search

oggy / looksee

Supercharged method introspection in IRB
MIT License
364 stars 14 forks source link

Make looksee#ls method worked together with pry 0.10.1 ls command. #30

Closed zw963 closed 9 years ago

zw963 commented 10 years ago

Pry 0.10.1 change command implementation.

With old looksee, it will make ls command in pry terminal not work.

This change will make ls command still work like this: (pry):0> ls, and Looksee#ls can work like this (pry):0> "hello".ls, just same as worked with pry 0.9.12.

zw963 commented 10 years ago

Thanks for this gem, this is the most usage gem I had found, NOT ONE OF ...

oggy commented 10 years ago

Thanks zw963!

The spec suite seems to be failing. Could you update the module name here as well?

./README.markdown 62:    Looksee::ObjectMixin
./README.markdown 110:    Looksee::ObjectMixin
./spec/looksee/adapter_spec.rb 42:        'Looksee::ObjectMixin',
./spec/looksee/core_ext_spec.rb 3:describe Looksee::ObjectMixin do
zw963 commented 10 years ago

Hi, I reimplement Looksee#ls with method_missing for worked with pry 0.10.

I skipped some spec about wirble, perhaps you want to fix this.

And, I do rebase before last push, hope it not confuse you a little.

changa commented 10 years ago

:+1:

zw963 commented 10 years ago

@oggy , no reply for a long time ...

oggy commented 9 years ago

I've finally merged your changes, except for 1 thing: I don't believe object.ls should behave differently if Irb or Pry is defined. You can always write your own wrapper around ls if you find the p arduous. I'll push out a release soon.

Thanks again, and sorry for the wait.

zw963 commented 9 years ago

Be revert before V3.1.0 :(

I locally can keep method_missing anyway, because i love word ls too much.

Thanks fancy looksee, it help me a lot !!